Use tcx.def_path_hash in ExistentialPredicate.stable_cmp
#91920
Conversation
This avoids a needless query invocation
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 4d1d66b with merge 8fed3a85418593390deb358b204d96de6346dc0b... |
|
☀️ Try build successful - checks-actions |
|
Queued 8fed3a85418593390deb358b204d96de6346dc0b with parent 404c847, future comparison URL. |
|
Finished benchmarking commit (8fed3a85418593390deb358b204d96de6346dc0b): comparison url. Summary: This change led to large relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
|
Perf doesn't see any changes in execution count and the one big perf change is likely noise |
|
If this is perf-neutral, I think we should merge it. There's no reason to perform a redundant query here, and this will unblock #91919 |
|
@bors r+ rollup |
|
📌 Commit 4d1d66b has been approved by |
bors
added
S-waiting-on-bors
Use `tcx.def_path_hash` in `ExistentialPredicate.stable_cmp` This avoids a needless query invocation
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91880 (fix clippy::single_char_pattern perf findings) - rust-lang#91885 (Remove `in_band_lifetimes` from `rustc_codegen_ssa`) - rust-lang#91898 (Make `TyS::is_suggestable` check for non-suggestable types structually) - rust-lang#91915 (Add another regression test for unnormalized fn args with Self) - rust-lang#91916 (Fix a bunch of typos) - rust-lang#91918 (Constify `bool::then{,_some}`) - rust-lang#91920 (Use `tcx.def_path_hash` in `ExistentialPredicate.stable_cmp`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This avoids a needless query invocation